jbrumwell / mock-knex

A mock knex adapter for simulating a database during testing
MIT License
240 stars 71 forks source link

knex.VERSION is deprecated #49

Closed gajus closed 8 years ago

gajus commented 8 years ago

A recent change to knex.js deprecated use of knex.VERSION, https://github.com/tgriesser/knex/commit/48a2ee16483636a1a3f5b28ad19769029352d5a3#diff-1fdf421c05c1140f6d71444ea2b27638R46.

As a result, mock-knex is producing the following warnings:

Knex:warning - knex.VERSION is deprecated, you can get the module versionby running require('knex/package').version
  ✖ loaders › BlogByBlogIdLoader › before failed with "Unable to locate version: 0.12.0"
Knex:warning - knex.VERSION is deprecated, you can get the module versionby running require('knex/package').version
  ✖ loaders › BlogByBlogIdLoader › after failed with "Unable to locate version: 0.12.0"
Knex:warning - knex.VERSION is deprecated, you can get the module versionby running require('knex/package').version
  ✖ loaders › PostsByBlogIdLoader › before failed with "Unable to locate version: 0.12.0"
Knex:warning - knex.VERSION is deprecated, you can get the module versionby running require('knex/package').version
  ✖ loaders › PostsByBlogIdLoader › after failed with "Unable to locate version: 0.12.0"
Knex:warning - knex.VERSION is deprecated, you can get the module versionby running require('knex/package').version
  ✖ loaders › UserByUserIdLoader › before failed with "Unable to locate version: 0.12.0"
Knex:warning - knex.VERSION is deprecated, you can get the module versionby running require('knex/package').version
  ✖ loaders › UserByUserIdLoader › after failed with "Unable to locate version: 0.12.0"
maxArturo commented 8 years ago

Hey @gajus this should be fixed in #52.

jbrumwell commented 8 years ago

Published in 0.3.5