search

jbrumwell / mock-knex

A mock knex adapter for simulating a database during testing
MIT License
239 stars 71 forks source link

adding support for knex 0.13 #69

Closed MikeEmery closed 7 years ago

MikeEmery commented 7 years ago

Fixes #68

One thing, I see that Bookshelf has a peerDependency of < 0.13 https://github.com/tgriesser/bookshelf/blob/master/package.json#L65, do I need to create a PR against bookshelf to update that?

I copied the client adapter from 0.12 with no changes.

jbrumwell commented 7 years ago

@MikeEmery Thank you for the PR :+1: We wouldn't require that, looks like they added that when 0.12 was released probably to avoid a situation where an update to knex breaks bookshelf. I'll run this tonight and get it published :) Thanks again!

gausie commented 7 years ago

Whats the situation with this currently?

jbrumwell commented 7 years ago

@MikeEmery Thank you for taking the time to put this together, I had some clean up to do in the platforms directory so I ended up doing it in another branch. :+1: Thank you :D 0.13

@gausie available in mock-knex@0.3.9 release just published

Thanks :)