search

jbrumwell / mock-knex

A mock knex adapter for simulating a database during testing
MIT License
239 stars 71 forks source link

Support for knex 0.18 #89

Closed opravil-jan closed 5 years ago

opravil-jan commented 5 years ago

Hi,

Can you add support for knex 0.18.x, please?

Thank you

Jan Opravil

opravil-jan commented 5 years ago

Hello,

would be nice to get support for knex 0.19.x.

Thank you

Jan Opravil

jbrumwell commented 5 years ago

WIll look at 18.x this weekend or sooner if I get time :)

skubot commented 5 years ago

Just curious, why do we need such tight validation on Knex version number?

jbrumwell commented 5 years ago

@skubot its good to know it is not supported and each version has its own implementation as some vary slightly, https://github.com/colonyamerican/mock-knex/tree/master/src/platforms/knex. I may add an optional override but it could result in tests failing/passing that should not.

jbrumwell commented 5 years ago

@opravil-jan @skubot Version 0.4.6 published with 0.18 and 0.19 support. Please let me know if you experience any issue :)

skubot commented 5 years ago

@jbrumwell thanks! Seems to be working well with 0.19