Change the way that risk assessment approval is saved. currently the fields are binary so 1 is approved and 0 is rejected, and null is not reviewed. This is in both booking and risk_assessment. These binary fields should be changed to risk_assessment_status, with 3 options. "Risk Assesment Approved", "Risk Assessment Rejected, and "Not Reviewed". Not reviewed would appear alphabetically before the others if you sort on this field. Also in risk assessment there is a field called approved_by and this should really be reviewed_by..

jbrun001 / roombooking

Creative Commons Zero v1.0 Universal

1 stars 1 forks source link

Change the way that risk assessment approval is saved. currently the fields are binary so 1 is approved and 0 is rejected, and null is not reviewed. This is in both booking and risk_assessment. These binary fields should be changed to risk_assessment_status, with 3 options. "Risk Assesment Approved", "Risk Assessment Rejected, and "Not Reviewed". Not reviewed would appear alphabetically before the others if you sort on this field. Also in risk assessment there is a field called approved_by and this should really be reviewed_by.. #45

Closed jbrun001 closed 7 months ago

jbrun001 commented 8 months ago

This will require, changes to the database, changes to the sql in app,js (because there will be new field names, and changes to the list pages and the view/edit/review pages where the risk assessment status is now displayed.

SpikeElliot commented 7 months ago

Issue solved as stated in commit.