search

jbrunton / gflows

A CLI tool that makes templating GitHub Workflows easy
MIT License
30 stars 3 forks source link

update go-jsonnet #207

Closed Meroje closed 2 years ago

Meroje commented 2 years ago

This fixes #128 (in a way) thanks to jsonnet's 0.18 feature of removing the quotes. Also, I had to update fsnotify as golang.org/x/sys would not compile on macos anymore.

https://github.com/google/jsonnet/releases/tag/v0.18.0

jbrunton commented 2 years ago

@Meroje: Nice! Thank you for the PR. I will review it this weekend.

jbrunton commented 2 years ago

Looks like some unrelated build issues, at least one of which is due to outdated dependency management. I'll fix on another branch.

jbrunton commented 2 years ago

@Meroje: I fixed the build issues on develop. Would you mind rebasing your branch?

The changes look good, I'll merge once the build passes. Thanks!

Meroje commented 2 years ago

sure :) thanks

Meroje commented 2 years ago

I think statik still has issues running, at least locally with act.

jbrunton commented 2 years ago

@Meroje: The build passed, so I merged your changes. I'll publish a release shortly.

Thanks for the contribution!