search

jbsf / blindside

Blindside provides dependency injection capabilities for Objective-C on iOS and OS X
MIT License
71 stars 43 forks source link

Exception on recursive dependency #33

Closed briancroom closed 9 years ago

briancroom commented 9 years ago

(This builds off the branch for #32 and shouldn't be merged until that PR has been merged until after that one.)

I'm looking for some feedback on both the concept and implementation here! It seems useful for me, since the infinite recursion that otherwise occurs doesn't provide users much help in fixing the issue.

I'm also wondering if it would be a worthwhile to explore the possibility of supporting cyclic dependencies when performing property injection?

CC @akitchen @idoru @tjarratt

akitchen commented 9 years ago

Cool, I've missed this in the past. Are there performance implications to this? I ask naively; merging :)

Thanks @briancroom !

briancroom commented 9 years ago

I'll try to take a few minutes to look into the performance implications today. My initial thought is that if you are in a situation where object instantiation performance is a tight constraint, you probably don't want to be using a highly dynamic, NSInvocation-leveraging library there anyway, but meh