jbszczepaniak / spotify-cli

Terminal client for Spotify
MIT License
176 stars 10 forks source link

OAuth Crash #1

Closed sabrehagen closed 4 years ago

sabrehagen commented 6 years ago

On Ubuntu 18.04, after receiving the OAuth redirect of

http://localhost:8888/spotify-cli?code=AQB9KRNPwgRsoP5vWerwi0mr0BpDMOwRuEVz-xWvO6Nq2KPEvA94aKEuz_8WQzkeMwKjCL5aYrFyVIobz29Gq8CnEwV6X84wpsdDZneeAC_766pu5jmHlXhQ9Wy8GJoLvNBgz-0CcriHdRwPLzg6A9sprG8JNkEijylYPUOHAXKmfri8RdMkapPwpf_R6P_q1uo6Dthz775mFt50wECCx-3GsX0m8YaHiPuByf3iDEhkjMkhiXkg7HHeaShgi5XwZGY7XfOVN17NwVoH4DfmgZwJJmN3u__tNfKbn7l0p1OnTa40RpBvl7WlgVQFuW9DDUar52TmrgA1xQl2BO1CvcRz5nASiAcA06Ka9yxkMx4gXIUJzPvvqqKvQJiNwICf-dNXV7GgpHMyJ84Gt1kDhHmF_NcHWvVJpAfkwSg8lgy8vz8&state=f3eee04d-57ee-43b5-8f83-f17d52666cc7

the terminal shows output of

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x7ab604]

goroutine 1 [running]:
main.main()
        /home/jackson/go/src/github.com/jedruniu/spotify-cli/main.go:100 +0x514
jbszczepaniak commented 6 years ago

Does this happen all the time, or sometimes? What version of go do yo have?

sabrehagen commented 6 years ago

All the time, and the head of master. f24106a

On Fri, 28 Sep 2018, 4:30 AM Jędrzej notifications@github.com wrote:

Does this happen all the time, or sometimes? What version of go do yo have?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jedruniu/spotify-cli/issues/1#issuecomment-425197146, or mute the thread https://github.com/notifications/unsubscribe-auth/ABCzyIEJIIVfcN-Ad6xt9lZLEAyJSLFfks5ufRlIgaJpZM4W8Cg6 .

jbszczepaniak commented 6 years ago

I have trouble reproducing this one to be honest, works for me on Ubuntu 18.04.

snippins commented 6 years ago

I have the exact same problem (Ubuntu 18.04), is there any chance it is because of different go version?

sabrehagen commented 6 years ago

I'm on go1.10.1 linux/amd64.

snippins commented 6 years ago

I'm on go1.11.1

jbszczepaniak commented 6 years ago

Let me recheck.

jbszczepaniak commented 6 years ago

@sabrehagen @snippins What browser do you use? I have some issues when using Firefox, with Chrome it is all right. I created fresh Ubuntu 18.04 installation, I installed golang, and go 1.10.1 linux/amd64 was installed. I used my existing spotify application for spotify account that has premium, and it jusy works. It doesn't however work with Firefox as default browser - but I don't see any traceback, you just run and it doesn't do anything after authentication.

sabrehagen commented 6 years ago

Is there a way we can improve debugging output? E.g. a longer stack trace?

On Thu, 4 Oct 2018, 5:11 AM Jędrzej notifications@github.com wrote:

@sabrehagen https://github.com/sabrehagen @snippins https://github.com/snippins What browser do you use? I have some issues when using Firefox, with Chrome it is all right. I created fresh Ubuntu 18.04 installation, I installed golang, and go 1.10.1 linux/amd64 was installed. I used my existing spotify application for spotify account that has premium, and it jusy works. It doesn't however work with Firefox as default browser - but I don't see any traceback, you just run and it doesn't do anything after authentication.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jedruniu/spotify-cli/issues/1#issuecomment-426762297, or mute the thread https://github.com/notifications/unsubscribe-auth/ABCzyGxUrbJxpbflSMuK27OnF_rsyteaks5uhQvOgaJpZM4W8Cg6 .

snippins commented 6 years ago

@jedruniu I have tried to set both Firefox and Chrome as default, same problem. I have removed my go installation and use the one provided by Ubuntu (sudo apt install golang) to have the exact same setup as you and still got this problem.

When I first try to build there is some complain about dependency, and I just use "go get" to install them, is this the correct way to do it?

snippins commented 6 years ago

Also music is still playing in my browser after the crash.

jbszczepaniak commented 6 years ago

I didn't try with go get, I was using README.md steps to install - but I will try go get as well. I will check today. As for music playing after crash - this is an issue - different one though.

jbszczepaniak commented 6 years ago

@snippins , @sabrehagen Maybe I will release ready binaries if you have such problems? Because I really tried hard to reproduce this problem and I can't.

sabrehagen commented 6 years ago

I'm happy to try those releases and report back.

On Sun, 7 Oct 2018, 5:45 AM Jędrzej notifications@github.com wrote:

@snippins https://github.com/snippins , @sabrehagen https://github.com/sabrehagen Maybe I will release ready binaries if you have such problems? Because I really tried hard to reproduce this problem and I can't.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jedruniu/spotify-cli/issues/1#issuecomment-427597375, or mute the thread https://github.com/notifications/unsubscribe-auth/ABCzyG4texXx00N4nbzbsWcieeo2fRqpks5uiPpZgaJpZM4W8Cg6 .

snippins commented 6 years ago

I'm happy to try those as well.

jkawczynski commented 6 years ago

@sabrehagen @snippins I've tested this release, works well for me

jbszczepaniak commented 6 years ago

Please try to use spotify-cli for your flavor: https://github.com/jedruniu/spotify-cli/releases/tag/v1.0.1 Note that you still have to have proper spotify application configured.

sabrehagen commented 6 years ago

I still get the following with v1.0.1:

> ./spotify-cli 
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x7c9135]

goroutine 1 [running]:
main.main()
        /Users/jedrzejszczepaniak/go/src/github.com/jedruniu/spotify-cli/main.go:100 +0x555
snippins commented 6 years ago

Exact same thing for me

 $ ./spotify-cli
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x7c9135]

goroutine 1 [running]:
main.main()
        /Users/jedrzejszczepaniak/go/src/github.com/jedruniu/spotify-cli/main.go:100 +0x555
jbszczepaniak commented 6 years ago

Guys sorry but I can't reproduce it.

jbszczepaniak commented 4 years ago

I fixed problems reported by users and released new versions Please consider using this one, also remember about requirements for running the project. I am closing this issue, if running newest release will be still problematic for you - feel free to reopen the issue.