Closed jbt closed 8 years ago
Overall, I think this is a good idea for the direction of the project. Like you mentioned already, there will be a big initial hit in language support. The list of languages can be viewed and compared here:
Personally, for my own use, Highlights would be better since it supports Sass, which is missing in Pygments. Looking at the list though, I do notice it's missing some template languages and notably C#
. I've heard that Atom can get weird with certain short tags, but haven't used it enough myself to say how specifically.
I think we should keep this open for discussion but might be a little too soon to make the switch. Perhaps a separate branch would be nice to start working on it though and try out some languages.
As for the modules, +1!
+1 for using other modules. +1 for using highlights
Extra feature suggestions:
Please add support for comments located same line with code. (like docco fork of you). Please note that docco fork has a bug which results not aligning this kind of comments in the same line with code. Example:
console.log('Foo'); // This outputs foo
I may suggest changes below for comments located same line. EDIT: This messes up other things, since I don't know inner working of the module exactly.
docker.js Line 499:
--- var commentRegex = new RegExp('^\\s*' + params.comment + '\\s?');
+++ var commentRegex = new RegExp('\\s*' + params.comment + '\\s?');
docker.js Line 592:
--- section.docs += line.replace(commentRegex, '') + '\n';
+++ var result = new RegExp('(.*)?\\s*' + params.comment + '\\s?(.*)?').exec(line);
+++ section.code += result[1] + '\n';
+++ section.docs += result[2] + '\n';
Thank you,
hey @jbt looking forward to this update.
I don't have any code to show for this yet because my experiments are too messy, but I'm interested to know people's opinions on the following propositions for the next major version:
If anyone has any thoughts or suggestions on this, or thinks any of these propositions are a Really Bad Idea, then do please reply.