search

jbt / docker

Documentation generator
http://jbt.github.com/docker
MIT License
234 stars 56 forks source link

--css and --js flags broken #98

Closed reiner-dolp closed 8 years ago

reiner-dolp commented 8 years ago

Using the --css and/or --js options results in the following exception in nodejs v4.4.5:

path.js:341
    throw new TypeError('ext must be a string');
    ^

TypeError: ext must be a string
    at win32.basename (path.js:341:11)
    at Array.map (native)
    at null.<anonymous> (node_modules\docker\src\docker.js:1338:26)

I had to substitute all lines containing map(path.basename) with 

map(function(file) {
    return path.basename(file);
})
jbt commented 8 years ago

I think this is the same as in #82 and should be fixed by #86 which (because I'm a terrible person, sorry!) has been neglected again, argh! I'll get that PR merged and 1.0 finalised this weekend.

reiner-dolp commented 8 years ago

You're right. That's an exact duplicate. Missed that one while scanning existing issues and pull requests.