search

jbt / markdown-editor

Live (Github-flavored) Markdown Editor
http://jbt.github.com/markdown-editor
ISC License
2.82k stars 643 forks source link

break_highlighting_resubmission #116

Closed cmnguyen01 closed 1 year ago

cmnguyen01 commented 4 years ago

provides a small fix to #101 based on the idea provided by aero31aero I created the disable warning button. codemirror error highlighting is done through its lint property. the highlighting is not as obtrusive as it was before.i tried adjusting the lint property to most aspect it does seems to work it still highlights but it does not highlight in a way that is consider bothersome. however when active there is an issue with where the mode is active it turns the functionality off for some of the other modes.this more or less just to provide a starting point for the fix though. I had resubmit due to an issue with my branch.

tomByrer commented 4 years ago

IMHO adding a test suite should be a separate PR. You really only added 3 lines of code (+2 dead lines) in the first PR, should have left it there.