search

jbt / markdown-editor

Live (Github-flavored) Markdown Editor
http://jbt.github.com/markdown-editor
ISC License
2.83k stars 644 forks source link

Support Task Lists in GFM #23

Open Vdragon opened 9 years ago

Vdragon commented 9 years ago

It seems that Task Lists still not rendered correctly.
https://github.com/blog/1375%0A-task-lists-in-gfm-issues-pulls-comments

jbt commented 9 years ago

Task lists unfortunately aren't supported in chjj/marked, which is the markdown rendering library this editor uses.

That said, I'm currently working on rearranging a whole load of code and potentially switching to markdown-it as the markdown parser, which doesn't have support for task lists out-of-the-box, but it has quite a nice plugin system so I'm sure it'll be possible to add.

One question: obviously task lists will render checkboxes into the final output - would you want the ability to be able to toggle them on and off and it change the markdown source, or would you be happy with them being readonly? (obviously readonly is quite a lot easier to implement)

Vdragon commented 9 years ago

Readonly would be fine for me.

jbt commented 9 years ago

I'll see what I can do then :)

jbt commented 9 years ago

Just FYI on this, after switching to markdown-it it looks like this would be very easy to do, but I don't like the available markdown-it-checkbox package (it doesn't give a nice way of applying a class to the enclosing <li>) so I'll have to see about putting something together myself. Shouldn't be too bad though.

carbontwelve commented 9 years ago

I'd like to be able to choose if I were to have a check-box or simply a graphic for the output or the ticked checkbox from font awesome.

wkoffel commented 9 years ago

Read-only is good for me too, this would be a helpful addition.

ooxi commented 8 years ago

It would be really great if this feature would be supported. This is the only reason I still use GitHub markdown API instead of this project.

fennecdjay commented 7 years ago

I'd like to support this.