Links with parenthesis mess up syntax highlighting

jbt / markdown-editor

Live (Github-flavored) Markdown Editor

http://jbt.github.com/markdown-editor

ISC License

2.83k stars 644 forks source link

Links with parenthesis mess up syntax highlighting #35

Open Qix- opened 9 years ago

Qix- commented 9 years ago

[some link](https://en.wikipedia.org/wiki/Tree_(data_structure)#Terminologies_used_in_Trees)

parses and is displayed correctly in live preview, but the syntax highlighting is incorrect.

jbt commented 9 years ago

This'll be an issue with CodeMirror's markdown mode. Looks like it's been updated upstream since I last grabbed it so I'll see about updating it and that may sort this.

That said, I really should round off and merge #25 which ditches CodeMirror entirely and would make things nicer to work with

jbt commented 9 years ago

Well I bumped to latest and that doesn't seem to have fixed it. I'll have a little dig around and see if it's feasible to try and figure out the necessary changes in codemirror or whether it'd be less effort to finish off that PR

Qix- commented 9 years ago

:+1: for prism. Does it properly handle the case I mentioned?

jbt commented 9 years ago

Yup, you can check out that version here