jbt / markdown-editor

Live (Github-flavored) Markdown Editor
http://jbt.github.com/markdown-editor
ISC License
2.82k stars 643 forks source link

Menu Bar and Split View Management. Closes #5 and Starts work on #57. #58

Closed aero31aero closed 6 years ago

aero31aero commented 8 years ago

Changes Documentation and Merge Guide

  1. Separated index.html to index.html/index.css/index.js.
  2. Added Menubar to expose editor functionality. Save button working, rest hidden. Starts work on #57 .
  3. Split View Management - This one is the important one. Solves #5 .

    Separated index.html

Careful while merging. Git will keep both the versions, so post-merge, you'd need some clean-up. As a good design practice I separated them. If need be, ask me to recombine them.

Menubar

Added a menubar on top of the screen. Had to make minor changes to box-shadow of the two editor views. Needs to be present for the future changes I plan to make: share to pastebin etc. hopefully.

Split View Management

When screen-size<1024(or whatever you initially set in media query) pixels,

  1. The default behavior is the same, i.e., HTML view goes full screen.
  2. By toggling the "Show Editor" button in the menu bar, the Editor view goes full screen.
  3. Click the button again to bring the HTML view to full screen.

When screen-size>1024 pixels, the default layout becomes visible with the split view as usual.

jbt commented 8 years ago

Sorry for not getting onto this yet - this looks great but I've been super-busy last few days. I'll get this merged as soon as I can :+1:

aero31aero commented 6 years ago

Closing this as this is redundant. Refer to #77