jbt / markdown-editor

Live (Github-flavored) Markdown Editor
http://jbt.github.com/markdown-editor
ISC License
2.83k stars 644 forks source link

broken table markdown is rendered 'correctly' but not on github #6

Closed jethroo closed 9 years ago

jethroo commented 11 years ago

first let me thank you for this nice editor! ;)

i just stumbled over a maybe not intended behaviour:

Item (unrounded)| Price (unrounded) | LareRound | Financial
 --- | --- | --- 
 item | 10.000 | 10.00 | 10.00
 tax  | 0.823  | 0.82  | 0.83
 **Total** | **10.823** | **10.82** | **10.83**

was rendered as 'correctly' as table in the editor although it was broken, should have been:

Item (unrounded)| Price (unrounded) | LareRound | Financial
 --- | --- | --- | ---
 item | 10.000 | 10.00 | 10.00
 tax  | 0.823  | 0.82  | 0.83
 **Total** | **10.823** | **10.82** | **10.83**

difference of both can be tested right in this comment:

Item (unrounded) Price (unrounded) LareRound Financial
item 10.000 10.00 10.00
tax 0.823 0.82 0.83
Total 10.823 10.82 10.83
Item (unrounded) Price (unrounded) LareRound Financial
item 10.000 10.00 10.00
tax 0.823 0.82 0.83
Total 10.823 10.82 10.83

sincerely yours

Carsten

thorsummoner commented 10 years ago

This might be an issue with the underling markdown rending engine, might be best to post your issue there as well: https://github.com/chjj/marked

jbt commented 9 years ago

Oops, sorry for lack of response on this. This is indeed an issue with marked, the rendering engine. I'm currently working on the possibility of switching to markdown-it as it's a lot better maintained and more pluggable, and it handles this case correctly