search

jbt / markdown-editor

Live (Github-flavored) Markdown Editor
http://jbt.github.com/markdown-editor
ISC License
2.82k stars 643 forks source link

add Dockerfile to help run in container (issue #66) #67

Closed zyfdegh closed 6 years ago

aero31aero commented 6 years ago

Hey! Thanks for your interest in the project! :grinning:

This PR, however, is incompatible for two main reasons:

  1. Encouraging using docker for such a small front-end-only project.
  2. Having a hard link to a specific directory in the Docker File(and OS, not going to function on Windows certainly).

I feel that such choices should be left to the user, and perhaps documenting various methods of running such a project locally would be a welcome change.

I have a small suggestion that I use for my development purposes.

cd ~/gitclones/markdown-editor
python3 -m http.server

Also, for more persistent usage, I've copied the folder to my Apache root to access is on localhost/md whenever I want.

I'm closing this PR for now. Feel free to reopen with a comment if you disagree.

Regards Rohitt