search

jbt / markdown-editor

Live (Github-flavored) Markdown Editor
http://jbt.github.com/markdown-editor
ISC License
2.82k stars 643 forks source link

New version does not look like github's markdown preview for code blocks #83

Closed ventz closed 6 years ago

ventz commented 6 years ago

Hi,

For some reason the new version does not look like github's preview (at least under Chrome). (Specifically around code blocks)

The older version was a perfect clone of github's markdown "preview".

aero31aero commented 6 years ago

Hey! Can you please show some screenshots of the issue? That'd be really helpful in debugging this.

ventz commented 6 years ago

image

ventz commented 6 years ago

Here is what it looks like on github:

image

aero31aero commented 6 years ago

I'm sorry I don't understand the difference. Are you talking of color scheme? Or is there some rendering issue I'm missing here.

The only change I notice is the background color being non-white, and that was for easing the contrast. I could undo that for a pure github experience, however.

ventz commented 6 years ago

Yea, I think it's just the color scheme -- the color bleed makes it so that the blocks don't stand out, and it "bleeds" into the background. At first I thought it wasn't placing the blocks at all -- but after looking at the screenshot, funny enough you can see the difference there.

If possible to get the background to be white and the color blocks to match the github "grey color" (RGB xF6F8FA I think?)

aero31aero commented 6 years ago

Fixed this. Thanks for reporting @ventz :tada:

ventz commented 6 years ago

@aero31aero - you are awesome! Thank you (and thanks for the quick fix!!)

Would you mind adding one more small color fix? (for the HR line when you use the # or ## or ###, etc)

From what I can tell, that's the only other item that doesn't show up well. Everything else shows up incredibly well.

By the way - your markdown preview is the only one that is easy/instant, and actually looks like github!!

aero31aero commented 6 years ago

Fixed that and some other similar colors in 3c1ee34 and deployed. Also, thanks! I've just recently begun maintaining and @jbt is the one who did all the initial hard work. :D