search

jbt / markdown-editor

Live (Github-flavored) Markdown Editor
http://jbt.github.com/markdown-editor
ISC License
2.82k stars 643 forks source link

FR: permalink to view with reading mode disabled #86

Closed aspiers closed 6 years ago

aspiers commented 6 years ago

A while ago I wrote a page explaining gotchas with Markdown lists. The main value of this page is gained when seeing the raw Markdown side-by-side with the rendered version. The above link used to show that, but now the Editor defaults to reading mode, so it's no longer useful.

I presume there was some good reason for changing the default view, but it doesn't work for this particular use case, so please can there be a way to permalink to content with reading mode disabled?

aero31aero commented 6 years ago

The reason was that some people were using this to write some text, and then use a url shortner to share the link with others primarily for viewing.

I had been thinking of having this controlled via query params, so the url would become something like:

https://jbt.github.io/markdown-editor?read=false&dark=true#68aV7tKiVYUCfyko9/4jWfwA=

Thanks for reporting this.

aspiers commented 6 years ago

Yes, something like that would be perfect. Thanks a lot for the quick reply!!

aero31aero commented 6 years ago

You should be able to use this like .../?reading=false#.... I'll add the UI for this later, but this should solve your purpose.

aspiers commented 6 years ago

@aero31aero Awesome! It now seems to default to reading mode disabled - that's fine by me obviously, but was it intentional?

aero31aero commented 6 years ago

Sort of... As in, I know why it's doing that and that it needs fixing, but I had some urgent college work to get to so I thought I'll fix that (and remove a bunch of logging statements) while figuring out a UI for this.

On Thu, Apr 5, 2018, 12:51 AM Adam Spiers notifications@github.com wrote:

@aero31aero https://github.com/aero31aero Awesome! It now seems to default to reading mode disabled - that's fine by me obviously, but was it intentional?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jbt/markdown-editor/issues/86#issuecomment-378715662, or mute the thread https://github.com/notifications/unsubscribe-auth/AHqT1vR2y7MeTYnb25Ge6PEL9wYF6Kwyks5tlR1JgaJpZM4THKsU .

aspiers commented 6 years ago

Ok just checking 😉