search

jbuchermn / newm

Wayland compositor
MIT License
960 stars 30 forks source link

Modpress or move with keyboard unzooms windows #102

Open CRAG666 opened 2 years ago

CRAG666 commented 2 years ago

This is bad easy a video is shown. But even if I explain what happens. For example when I edit videos I like to have a larger kdenlive window, and other smaller windows, the problem is that when I move with the keyboard the zoom is canceled, this also happens with modpress

https://www.veed.io/view/04625a8b-4928-490f-b21b-a7cd4c68cf0b?sharingWidget=true

jbuchermn commented 2 years ago

This is intentional, scaling, as in overview mode, does not look nice with full screen windows. Especially animations have slot of rounding artifacts.

If you don't mind the visual aspects, I'll take a look into adding a config option to disable this behaviour.

CRAG666 commented 2 years ago

Well really the problem is that the zoom is reset when you press mopress. But this only happens when the windows are not the same size

jbuchermn commented 2 years ago

Yup as mentioned above this is intentional, but if it's easily possible we can enable configuring it differently

CRAG666 commented 2 years ago

@jbuchermn thanks :)

jbuchermn commented 2 years ago

You can now set view.sticky_fullscreen to True to disable this behaviour.

CRAG666 commented 2 years ago

I just tried exactly that and it seems not functional the behaviour is still the same, for example I have 3 windows 2 of the normal size and 1 occupying half of the screen, I zoom and everything good as soon as I move to another window the zoom is destabilized :(

@jbuchermn

screen-1657809499

jbuchermn commented 2 years ago

Can you describe a bit better what you mean? Unfortunately your original video is no longer there and it's a bit hard to follow your description.

Switching to fullscreen and then swiping between the windows does no longer exit fullscreen mode, going to overview neither, but 4-finger-swiping to zoom still does - do you mean that?

CRAG666 commented 2 years ago

https://user-images.githubusercontent.com/34254373/179030664-b56a41d9-89a4-4e9b-b05d-09e91ea8a43b.mp4

CRAG666 commented 2 years ago

@jbuchermn In the video I have 4 windows, one of them is larger than the others, so I make mod+u to zoom, I sail for the sale but at the moment I return with mod+j the zoom is canceled, this behavior don't want it to happen, I want it to be kept in zoom mode even if the windows are of different size

CRAG666 commented 2 years ago

@jbuchermn I am willing to receive a no with this characteristic.However, it is quite useful with applications such as Kdenlive, since it would work in too much to those who have small monitors or a only monitor (right now I do not have a second monitod).Thank you very much for your excellent job