jbuchermn / newm

Wayland compositor
MIT License
960 stars 30 forks source link

layout.move(): skip animation when no panning is needed #128

Closed edrex closed 1 year ago

edrex commented 2 years ago

As a new user, I perceived an uncomfortable period of delay when moving focus between windows with the keyboard motions. I believe this is because even when no panning is needed, layout.move(...) waits out the animation period before updating the focus halo.

Suggested change: when no panning is needed, layout.move(...) could skip animation or otherwise tighten it up.

Reports

From new user experience report #127:

Shifting focus with Mod+[hjklunt] seems uncomfortably laggy, maybe due to some gesture processing latency?

Also I think this is the nit mentioned by @sadrach-cl.

Now, how can I (...) increase the speed when pressing commands like "logo+HJKL"?

jbuchermn commented 2 years ago

Thanks for reporting! You're completely right in diagnosing the problem; actually that's been bothering me for some time but I haven't come round to fixing it.

I'll take a look, this should be really straight-forward.

jbuchermn commented 2 years ago

I just pushed to master - can you try?

edrex commented 2 years ago

It seems like there is still some delay, perceptible but small. Maybe a different cause?

jbuchermn commented 2 years ago

It's weird that the blue halo (in config it's called focus_border) is gone for you. I don't experience any issues with it.

Did you change anything concerning the relevant configuration?

I'd focus on that first, maybe there is some issue causing related delay.

Edit: I just did some experimenting with 5-6 alacritty windows and I really was not able to see any perceptible delay (100ms should be noticeable I think...) - what kind of apps are you using?