search

jbuchermn / newm

Wayland compositor
MIT License
960 stars 30 forks source link

Recent renderer changes on v0.3 / debug - performance issues #61

Closed jbuchermn closed 2 years ago

jbuchermn commented 2 years ago

Recently there have been a lot of changes on v0.3 regarding rendering and timing.

This issue is meant to track any performance related problems happening now, especially non-smooth animations and gestures (low fps, dropped frames).

If you're experiencing any issues: Please check out the debug branch on pywm (v0.3 on newm), run newm for a very short time (maybe two or three low-performance animations, like 5 seconds in total) and upload the log file. Thanks!

@CRAG666 @DimitrisMilonopoulos

EDIT - Findings

CRAG666 commented 2 years ago

@jbuchermn understrood :)

CRAG666 commented 2 years ago

I'm currently on the debug branch. Animations are clunky and slow on the second monitor on the main monitor they work fine

CRAG666 commented 2 years ago

@jbuchermn log https://drive.google.com/file/d/1ovHpkv5gnig5MlzmXWT3xTpuod1sCLcX/view?usp=sharing

CRAG666 commented 2 years ago

my current config https://github.com/CRAG666/dotfiles/blob/master/config/newm/configV3.py

jbuchermn commented 2 years ago

Thanks for the log, I'm studying it at the moment.

At first sight it looks like the two monitors perform quite differently (one looks okay, one looks very bad) - is this true, or do you see equally bad animations on both screens?

jbuchermn commented 2 years ago

Also.. I just realized, I made some git errors, so only now is damage branch up-to-date with v0.3. Would you mind trying again?

CRAG666 commented 2 years ago

@jbuchermn I just updated and if the error is still present, as I already mentioned, the error only occurs on the second monitor

jbuchermn commented 2 years ago

Can you also upload a new log?

CRAG666 commented 2 years ago

I'm a fool, compile v3 instead of debug. Debug works perfect.

CRAG666 commented 2 years ago

@jbuchermn the debug branch works very well, no latency or delays in the animations, everything goes very smoothly

jbuchermn commented 2 years ago

That‘s good to hear, although I'm not really confident this is consistent. For me, I do see occasional slow animations. Something about the timing is still off...

CRAG666 commented 2 years ago

@jbuchermn v3 already has the debug changes?

CRAG666 commented 2 years ago

If there is a delay I admit it but it is minimal very very minimal but if it improves it would be fine but for now I am satisfied

jbuchermn commented 2 years ago

@jbuchermn v3 already has the debug changes?

At the moment not. But I want to merge soon.

However, I just pushed major changes (again...) to debug. Can you try and see if there is lag or are any artifacts, ...? For me it appears to be more performant now.

Btw... renderer_mode does not need to be set anymore (also it has new values, wlr for passthrough and pywm for what was direct / indirect)

CRAG666 commented 2 years ago

thank, right now check the new changes and its configuration in nix

CRAG666 commented 2 years ago

@jbuchermn the debug branch works perfect. The experience is smoother now. I don't know if it has anything to do with it, but the representation of colors had a significant change. The colors are very vivid! this is amazing.

jbuchermn commented 2 years ago

That's great to hear :) I just merged debug into v0.3