search

jbuckmccready / CavalierContours

2D polyline library for offsetting, combining, etc.
MIT License
427 stars 79 forks source link

Bugfix: correctly set value of startofPlineBSlicesIdx #45

Closed karl-nilsson closed 3 years ago

jbuckmccready commented 3 years ago

Fix looks good to me...

@karl-nilsson If you're using this project do you have any interest maintaining it and fixing the tests? I can do whatever is needed to make you a direct maintainer.

The tests use google-tests and it looks like CMake fails to fetch it from the repo... (also I think the polyline extent tests give a false positive/fail).

I only plan to continue work on the Rust code here.

jbuckmccready commented 3 years ago

To fix the tests you could either add google-test as submodule, or figure out why CMake fails to fetch it (maybe something changed in the google repo) , or pick another C++ test framework and convert the tests over.

karl-nilsson commented 3 years ago

Looks like googletest moved from 'master' to 'main', and deleted the former. I'll submit a separate PR to fix it. https://github.com/google/googletest/issues/3663

Regarding maintainership, I don't have the time or expertise necessary to maintain this project, but I appreciate the offer.