search

jbuckmccready / cavalier_contours

2D polyline/shape library for offsetting, combining, etc.
Apache License 2.0
144 stars 12 forks source link

10 improve intersect functions documentation #18

Closed Nevsden closed 2 years ago

Nevsden commented 2 years ago

adds content (and possibly solves) #10

jbuckmccready commented 2 years ago

Thanks for the contribution! It looks great, just one or two things I noticed I will put in a review.

jbuckmccready commented 2 years ago

I pushed some changes to the master branch to fix https://github.com/jbuckmccready/cavalier_contours/issues/20 - I had to add an epsilon parameter to the intersect functions, it may be worth adding something in the documentation about how it controls float fuzzy comparing.

Nevsden commented 2 years ago

I will try to embed your comments in the next few days. Due to work I had not have any spare time to finish this issue.

jbuckmccready commented 2 years ago

@Nevsden I got things up to date with the added epsilon parameters and made some minor edits, thanks for the contribution!