search

jbuehl / solaredge

SolarEdge inverter logging data capture
GNU General Public License v3.0
289 stars 60 forks source link

define names for new messages (seCommands.py) #53

Open oliv3r opened 7 years ago

oliv3r commented 7 years ago

Hey all,

I want to add new defines that are missing. The obvious one that comes to mind is of course 0x003d for the encrypted message (which is just a wrapper around 0x0500 messages, I know). Which btw, if it where up to me, I'd probably name it something along the lines of: PROT_CMD_MISC_PAYLOAD_ENC or something. But I want to stay in sync as much as possible with the 'source dumps' of the apps (which makes things just so much easier in the future potentially). I know that these initial defines/enums come from the ver2 'control' application. ver3 isn't that popular but may contain these descriptions? I haven't found a working link to ver3 however ... (anybody?)

The other one I've found missing so far is 0x0503 which obviously is the command that gets the encryption key? (The pubkey is with SE?, each machine holds the PRIVKEY in 16 bytes at parameters 0x0239 - 0x023c) PROT_CMD_INVERTER_GET_PRIVKEY comes to mind, but these seem to sandwiched in between the VENUSMNGR commands? I guess they ran out of ... something? (I think it is save to assume they are keeping commands unique across products)

I'll be reading comment #8 again (boy it is long, though I did read all of it 3 months ago)

Otherwise I'll create the PR with the suggested values here.

oliv3r commented 7 years ago

@jerrythafast @whizkidzz hey guys, Do you still have the v3 .Net application? Does it contain these variables as well? Meanwhile I have read comment 8 a bit more (hence the mention) and learning new things that i missed the first time going over it.