jbufu / openid4java

Automatically exported from code.google.com/p/openid4java
Apache License 2.0
98 stars 58 forks source link

Cannot configure HttpClient via HttpClientBuilder #211

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Try to configure HttpClient via HttpClientBuilder.
2. Fail because openid4java uses its own HttpClientFactory instead, which calls 
the DefaultHttpClient constructor.

What is expected?
openid4java uses an injectable HttpClientBuilder to construct its HttpClient.

What version of the product are you using? On what operating system?
0.9.8

Please provide any additional information below.
DefaultHttpClient is deprecated and shouldn't be used directly.

Original issue reported on code.google.com by caspar.k...@gmail.com on 17 Jun 2014 at 8:14

cryptomilk commented 7 years ago

This is reason why SNI support with OpenID in Gerrit doesn't work.

https://bugs.chromium.org/p/gerrit/issues/detail?id=5047

jukedom commented 6 years ago

@cryptomilk exactly, there is an existing fork that supports SNI : https://github.com/jbufu/openid4java/pull/219.