Better support for Record Classes and Base Class for TsExportInterface

jburzynski / TypeGen

Single-class-per-file C# to TypeScript generator

MIT License

197 stars 56 forks source link

Better support for Record Classes and Base Class for TsExportInterface #165

Closed dersia closed 1 year ago

dersia commented 1 year ago

this fixes #164

When Record Class Types are used the c# compiler generates IEquatable for those classes. When exported as Interface or Classes, those will be generated too. I added a flag in the options to exclude those. I also added a cli flag to activate this option.

In #104 there is this point:

If the C# class has a base class, then all those properties must also be included This PR kind of solves this for interfaces. When a class has a base class that has also the TsExportInterfaceAttribute, and when the new flag is set this will make sure, that the interface is extended by the base class interface too.

jeanbern commented 1 year ago

I'm not affiliated with the project or anything, but one comment I have is that providing a true/false to your new consoleArgs seems like a lot of unnecessary complexity. Why not have it true if present and false otherwise like the other options do?

jburzynski commented 1 year ago

Thanks for the PR,

Records generation should be fixed in version 4.5.0 by the type blacklist. The blacklist was added to solve other problems that have been happening when interfaces or framework-specific types were being generated, but they shouldn't. IEquatable is added to this blacklist by default, so records should now be generated correctly.

As for the TS class : TS interface inheritance, I just added it without the option to disable this behavior. Previously when there was this kind of inheritance, an exception was thrown (at least in some cases). So now it can be regarded just as new functionality which was not there before.