search

jbusecke / cmip6_omz

MIT License
2 stars 0 forks source link

Test for muli threshold case + fix bug with upper/lower boundary. #43

Closed jbusecke closed 3 years ago

jbusecke commented 3 years ago

The old version did not deal properly with cases where none of the watercolumn was above the given threshold (omz expands all the way to the surface or bottom). This sets values to nan in such a case.

codecov[bot] commented 3 years ago

Codecov Report

Merging #43 (ea78c1d) into main (fa2da32) will increase coverage by 0.62%. The diff coverage is 47.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   45.37%   45.99%   +0.62%     
==========================================
  Files          14       14              
  Lines         659      674      +15     
==========================================
+ Hits          299      310      +11     
- Misses        360      364       +4
Flag Coverage Δ
unittests 45.99% <47.82%> (+0.62%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmip6_omz/boundaries.py 28.57% <0.00%> (-3.01%) :arrow_down:
cmip6_omz/utils.py 0.00% <0.00%> (ø)
tests/test_boundaries.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 47e3ab8...ea78c1d. Read the comment docs.