search

jbweston / miniver

Like Versioneer, but smaller
Creative Commons Zero v1.0 Universal
53 stars 10 forks source link

Clarify relation to setuptools #27

Open akhmerov opened 4 years ago

akhmerov commented 4 years ago

Miniver imports setuptools, and therefore may fail in some environments. Is this intentional? Should packages using miniver have setuptools as a requirement?

jbweston commented 3 years ago

Hi Anton,

The only reason setuptools is used is because this is the Python packaging stack that I am most familiar with. I was under the impression that the major Python distributions all ship with setuptools (even if it is not part of the standard library); could you elaborate on what environments you had in mind?

My understanding of newer technologies like Poetry is that they make extensive use of pyproject.toml to specify version metadata. I am not sure how this would interact with the need to dynamically obtain the version info from git.

akhmerov commented 3 years ago

Hey Joe, thanks for the explanation!

I rather meant this as a point for miniver users, and as as a suggestion to write in the README what the users need to specify for the package to be miniver-compatible.

Regarding your last remark, there's seemingly https://pypi.org/project/poetry-dynamic-versioning/ (despite what the readme says, poetry will support plugins in the next version).