Open DimitriPapadopoulos opened 1 year ago
I believe the encoding declaration # -*- coding: utf-8 -*- is not needed any more as far as Python 3 is concerned. Do you rely on other tools (like your IDE or text editor) to make use of that information? https://github.com/jbweston/miniver/blob/9624074bba080cde5d87ae664e74d1250100d333/setup.py#L1 https://github.com/jbweston/miniver/blob/9624074bba080cde5d87ae664e74d1250100d333/miniver/app.py#L69 https://github.com/jbweston/miniver/blob/9624074bba080cde5d87ae664e74d1250100d333/miniver/_static_version.py#L1 https://github.com/jbweston/miniver/blob/9624074bba080cde5d87ae664e74d1250100d333/miniver/_version.py#L1
# -*- coding: utf-8 -*-
In any case it is not used consistently in all files, I would recommend removing it from all files or adding it to all files.
I believe the encoding declaration
# -*- coding: utf-8 -*-is not needed any more as far as Python 3 is concerned. Do you rely on other tools (like your IDE or text editor) to make use of that information? https://github.com/jbweston/miniver/blob/9624074bba080cde5d87ae664e74d1250100d333/setup.py#L1 https://github.com/jbweston/miniver/blob/9624074bba080cde5d87ae664e74d1250100d333/miniver/app.py#L69 https://github.com/jbweston/miniver/blob/9624074bba080cde5d87ae664e74d1250100d333/miniver/_static_version.py#L1 https://github.com/jbweston/miniver/blob/9624074bba080cde5d87ae664e74d1250100d333/miniver/_version.py#L1In any case it is not used consistently in all files, I would recommend removing it from all files or adding it to all files.