search

jbweston / miniver

Like Versioneer, but smaller
Creative Commons Zero v1.0 Universal
53 stars 10 forks source link

add '--tags' option to 'git describe' #7

Closed basnijholt closed 6 years ago

basnijholt commented 6 years ago

This seemed to be needed to get minver to work here.

jbweston commented 6 years ago

Thanks for taking the time!

As I said on issue #6, I don't think it's a good idea to force everyone to use unannotated tags because this is not the Right Way to make a release.

This could definitely be a configurable option, however I'm not sure how to easily integrate this configuration into the rest of miniver.

It's easy to add a use_unannotated_tags parameter to get_version, but the end user would have to configure this by changing this line, which is kind of awkward.

jbweston commented 6 years ago

I carried over your lint fixes, but as I mentioned in #6 I think it's best not to force people to use unannotated tags for versioning, as this is not what they're for.