jbx-protocol / juice-interface

🧃 An app for using the JBX protocol.
https://juicebox.money
MIT License
195 stars 126 forks source link

Add ability to link to payments #2765

Closed tomquirk closed 1 year ago

tomquirk commented 1 year ago

As an MVP:

  1. click on payment somehow (share button?)
  2. Link copied to clipboard and added to URL bar as a hash route (juicebox.money/@juicebox#payment_xyz
  3. Visually indicate this somehow (outline on the payment? slightly shaded background color?)

When landing on a payment:

wraeth-eth commented 1 year ago

This is definitely non-trivial :(

I wouldn't bring this one into current sprint unless you think it is paramount to goals. Either that or maybe need to be reassigned. wdyt @tomquirk ?

tomquirk commented 1 year ago

ya its a biggie. I really do think we should prioritize it though.

Ive updated description with what i think could be mvp. Don't think this would be thaaaat big of a lift. WDYT @wraeth-eth ?

wraeth-eth commented 1 year ago

There is some stuff to consider though. The big one that comes to mind is pagination id and how we load history etc.

We can definitely get recent txs easy, but its the older more buried ones that will be a problem (and these will exist as people share tx)

We also need to consider wha the ograph and other SEO of those links should look like. We probably want to make them the focus of their SEO

wraeth-eth commented 1 year ago

I think this is like 2 weeks of work tbh

tomquirk commented 1 year ago

@wraeth-eth sorry i probably wasn't explaining well enough what i was thinking for MVP.

This is all it is: https://github.com/jbx-protocol/juice-interface/pull/2978/files

Using that as a base, we can do the fancy stuff later (better OG, styling etc.)

wraeth-eth commented 1 year ago

Yeah that sounds GTM!