search

jbyuki / venn.nvim

Draw ASCII diagrams in Neovim
MIT License
919 stars 20 forks source link

Ascii drawing #33

Open matu3ba opened 2 months ago

matu3ba commented 2 months ago

@jbyuki I dont quite understand the idea behind the code separations yet, I would rename everything with appendix '_utf' and duplicate logic before unifying. Or do you have other opinions?

I should very likely do something faster for verbatim replacements rather than manually typing

rg -l -F 'parse' | xargs -n1 sed -i 's;parse;parse_utf;g'`
jbyuki commented 2 months ago

Related to #27

jbyuki commented 2 months ago

@jbyuki I dont quite understand the idea behind the code separations yet, I would rename everything with appendix '_utf' and duplicate logic before unifying. Or do you have other opinions?

Why not suffix the new code with a suffix instead of renaming everything? Code duplication is fine (also file duplication).

If you need to implement a new drawing logic, this is what I understand of being one of the goal of this PR, the best would be to create a new *.t file in primitives/. Just like box_over.lua.t was implemented after the initial implementation which has a different logic for drawing.