Various improvements - Githubissues

jc-SpaceXp / cNES

NES emulator written in C and targeted for Linux.

zlib License

6 stars 4 forks source link

Various improvements #1

Closed francois-berder closed 5 years ago

francois-berder commented 5 years ago

Fix build failure (obj directory was not created and SDL link errors)
Improve Makefile to support parallel builds
Fix warnings
Fix memory leaks in main
Better handling cartridge load failure

jc-SpaceXp commented 5 years ago

I didn't mean to approve all 12 commits initially, just one I was looking at.

jc-SpaceXp commented 5 years ago

Many of these changes overlap with the cleanup branch that I've been working on recently i.e. malloc checking and SDL_Delay(). I will look over these changes over the next few days and merge appropriately.

francois-berder commented 5 years ago

Hello, In that case, I will close this pull request and open one later. Let me know if you merge cleanup branch to master. François

jc-SpaceXp commented 5 years ago

Hi, I've just merged my cleanup branch to master.

francois-berder commented 5 years ago

Hi, I've just rebased my patches on top of the master branch.

jc-SpaceXp commented 5 years ago

Hi, I'm going to look through these changes soon!