Improve notifications - Githubissues

jc00ke / guard-puma

Restart puma when files change

MIT License

50 stars 19 forks source link

Improve notifications #30

Closed AlexWayfer closed 6 years ago

AlexWayfer commented 6 years ago

Don't include port in notification message when :config option is setted
Add option for notifications disabling

In GNOME DE system notifications has longer delay than Puma is restarting, so "Restarting" notification is useless: you see notification about Puma is restarted with delay.

Also, rename #run_on_change to #run_on_changes: https://github.com/guard/guard/wiki/Upgrade-guide-for-existing-guards-to-Guard-v1.1

jc00ke commented 6 years ago

Thanks! I want to look at this a bit closer over the weekend.

AlexWayfer commented 6 years ago

OK, thank you! I'm ready to listen to comments.

jc00ke commented 6 years ago

Thank you @AlexWayfer!