Improvements - Githubissues

jc00ke / guard-puma

Restart puma when files change

MIT License

50 stars 19 forks source link

Improvements #31

Closed AlexWayfer closed 6 years ago

AlexWayfer commented 6 years ago

Add pumactl option
Improve guard-compat using (https://github.com/guard/guard-compat#migrating-your-api-calls)
Don't notify about start when no start
Don't stop Puma if it was started not by Guard
Remove unused pry dependency
Update versions of dependencies

jc00ke commented 6 years ago

Cool, thank you! This seems like a lot to go into one PR, let alone one commit. Could you at least break apart each bullet point into a separate commit? Ideally there'd be multiple PRs for isolated changes, but I'll concede that that would probably be annoying, so I won't ask.

AlexWayfer commented 6 years ago

Oh. I know, but there are many related changes :sweat_smile:

OK, I'll try.