Update --control to --control-url for Puma >= 5.0.0

jc00ke / guard-puma

Restart puma when files change

MIT License

50 stars 19 forks source link

Update --control to --control-url for Puma >= 5.0.0 #43

Closed ianks closed 4 years ago

ianks commented 4 years ago

In Puma 5.0.0, --control is now an ambiguous argument, deprecated in favor of --control-url. This PR makes it so guard-puma will use --control-url on Puma 5.0.0.

see https://github.com/puma/puma/blob/master/History.md#500--2020-09-17

jc00ke commented 4 years ago

Good catch, thanks for opening the PR! Can you address the test failures as well, then I'll merge and release.

ianks commented 4 years ago

done!

jc00ke commented 4 years ago

The problem I'm seeing now is that the specs fail under Puma 4 but pass under Puma 5. I'm not ready to drop support for Puma 4; can you modify this PR so that it works under both?