Constructors for classpath of Maven Project should accept var args

simonjenga commented 8 years ago

The following constructors should be refactored in order to accept variable arguments. At the moment they can only accept one String argument e.g. "runtime" or "compile"

/**
 * Public ctor.
 * @param prj The Maven project
 * @param repo Local repository location (directory path)
 * @param scp The scope to use, e.g. "runtime" or "compile"
 */
public Classpath(final MavenProject prj, final File repo,
    final String scp) {
    this(prj, repo, Arrays.asList(scp));
}

/**
 * Public ctor.
 * @param bldr Dependency graph builder.
 * @param sess Maven session.
 * @param scp The scope to use, e.g. "runtime" or "compile"
 */
public MavenClasspath(final DependencyGraphBuilder bldr,
    final MavenSession sess, final String scp) {
    this(bldr, sess, Arrays.asList(scp));
}

Once the refactoring is done, it will be possible to pass more that one argument for the scope to use e.g: "runtime", "compile", "test", "system", "provided"

dmarkov commented 8 years ago

@yegor256 please pay attention to this issue (par.21)

dmarkov commented 8 years ago

@simonjenga thank you for reporting this, I added 15 mins to your acc, transaction 90841318

dmarkov commented 8 years ago

@amihaiemil the task is yours