search

jcabi / jcabi-beanstalk-maven-plugin

Maven Plugin for AWS Elastic Beanstalk
http://beanstalk.jcabi.com/
Other
11 stars 10 forks source link

WarFile.java:134-135: Implement validation of YAML inside... #15

Closed dmarkov closed 8 years ago

dmarkov commented 9 years ago

Puzzle 2-c30faef8 in src/main/java/com/jcabi/beanstalk/maven/plugin/WarFile.java:134-135 has to be resolved: Implement validation of YAML inside the method AbstractBeanstalkMojo.validYaml. Remember to unit test your solution.... The puzzle was created by Dmitri Pisarenko on 22-Jan-2015.

If you have any technical questions, don't ask me, submit new tickets instead

dmarkov commented 9 years ago

@maurezen the task is yours please proceed

maurezen commented 9 years ago

@dmarkov please assign this to another developer.

maurezen commented 9 years ago

@dmarkov @yegor256 any comments?

yegor256 commented 9 years ago

@dmarkov let's assign this to someone else pls

dmarkov commented 9 years ago

@dmarkov let's assign this to someone else pls

@yegor256 I'll ask somebody else to pick this up

dmarkov commented 9 years ago

@nhekfqn the issue is yours, please help

dmarkov commented 9 years ago

@marcuss please go ahead with this task, it's yours

dmarkov commented 9 years ago

@marcuss you're working with this ticket for the last 15 days. If it is not closed within the next 48 hours, it will be re-assigned to someone else, see No Obligations principle. This article should help if you're stuck... do not forget that you should remove the @todo puzzle from the source code... added -30 to your rating, now it is equal to -60

dmarkov commented 9 years ago

@tmjee please go ahead, it's your task now, keep this in mind, and don't hesitate to ask any technical questions you may have

Task's budget is 30 mins (see this for explanation)

tmjee commented 9 years ago

@dmarkov Any reason why validation has to be done in AbstractBeanstalkMojo.validYaml instead of WarFile? Json validation is being done in WarFile, it seems weird to spread out the validation

tmjee commented 9 years ago

@dmarkov created #26, which might be related to this as well.

tmjee commented 9 years ago

@dmarkov probably want to fix #27 first? or else I'll need jdk7 which i haven't got installed now

tmjee commented 9 years ago

@dmarkov fixed in #28

dmarkov commented 9 years ago

@dmarkov Any reason why validation has to be done in AbstractBeanstalkMojo.validYaml instead of WarFile? Json validation is being done in WarFile, it seems weird to spread out the validation

@tmjee try to avoid asking technical questions in the ticket. if something is not clear, it's a bug in the project, see http://www.yegor256.com/2015/01/15/how-to-cut-corners.html

dmarkov commented 9 years ago

@dmarkov created #26, which might be related to this as well.

@tmjee OK thanks

dmarkov commented 9 years ago

@dmarkov probably want to fix #27 first? or else I'll need jdk7 which i haven't got installed now

@tmjee it's up to you

tmjee commented 9 years ago

@dmarkov Merged. Pls close issue. Thx

dmarkov commented 9 years ago

@dmarkov Merged. Pls close issue. Thx

@tmjee sure, will do right after the next deployment cycle

dmarkov commented 9 years ago

@tmjee you're holding this task for 15 days already

do not forget that the ticket will be closed once the @todo puzzle is removed from the code, in master branch

added -30 to your rating, now it is equal to +15

tmjee commented 9 years ago

@dmarkov That's fine. removed @todo in pull request. Please do not assign any more issues to me. Thank you very much.

dmarkov commented 9 years ago

@dmarkov That's fine. removed @todo in pull request. Please do not assign any more issues to me. Thank you very much.

@tmjee sure, no problem. if you don't want any more tickets, post @alice away into Netbout

dmarkov commented 8 years ago

@yegor256 Closed, done, thanks all