WarFile.java:147-148: Implement validation of JSON inside... #16

[dmarkov]

Let me find a reviewer for this pull request, thanks for submitting it

[dmarkov]

@krzyk please review

[krzyk]

@nhekfqn few comments above, and you should add a test for invalid json also

[nhekfqn]

@krzyk please review.

[krzyk]

@nhekfqn we are almost there :), see my comments above

[nhekfqn]

@krzyk

you could just add @Test(expected = MojoFailureException.class)

I know, but I couldn't check exception message in that case. MojoFailureException can be thrown from three places in WarFile.checkEbextensionsValidity so its message does matter.

Other defects fixed, please review.

[krzyk]

@nhekfqn You can use ExpectedException for checking message

[nhekfqn]

@krzyk please review.

[krzyk]

@nhekfqn a comment about todo formatting

[nhekfqn]

@krzyk Please review.

[krzyk]

@rultor merge pls

[rultor]

@rultor merge pls

@krzyk OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge pls

@krzyk Done! FYI, the full log is here (took me 8min)

[dmarkov]

@krzyk done, I added 17 mins in payment 51683416... extra minutes for review comments (c=2)... added +17 to your rating, now it is equal to +4210

[dmarkov]

@rultor deploy

[rultor]

@rultor deploy

@dmarkov OK, I'll try to deploy now. You can check the progress here

[rultor]

@rultor deploy

@dmarkov Done! FYI, the full log is here (took me 6min)