search

jcabi / jcabi-beanstalk-maven-plugin

Maven Plugin for AWS Elastic Beanstalk
http://beanstalk.jcabi.com/
Other
11 stars 10 forks source link

Issue #15 WarFile.java:134-135: Implement validation of YAML inside. #28

Closed tmjee closed 8 years ago

tmjee commented 8 years ago

Issue #15

dmarkov commented 8 years ago

@tmjee Thanks for your pull request, let me find someone who can review it

dmarkov commented 8 years ago

@dmzaytsev please review, thanks

dmzaytsev commented 8 years ago

@tmjee AbstractBeanstalkMojo.execute() not tested, let's test it

dmzaytsev commented 8 years ago

@tmjee please see 7 comments above

tmjee commented 8 years ago

@dmzaytsev Test for AbstractBeanstalkMojo.execute() added.

dmzaytsev commented 8 years ago

@tmjee thank you just 5 minor comments above

tmjee commented 8 years ago

@dmzaytsev Done. thx.

dmzaytsev commented 8 years ago

@tmjee thanks one more comment

dmzaytsev commented 8 years ago

@tmjee sorry 3 cosmetic comments

tmjee commented 8 years ago

@dmzaytsev Done. thx

dmzaytsev commented 8 years ago

@tmjee thank you

dmzaytsev commented 8 years ago

@rultor merge

rultor commented 8 years ago

@rultor merge

@dmzaytsev Thanks for your request. @yegor256 Please confirm this.

yegor256 commented 8 years ago

@tmjee a few comments from me

tmjee commented 8 years ago

@yegor256 Done.

yegor256 commented 8 years ago

@tmjee a few more comments from me

tmjee commented 8 years ago

@yegor256 done.

yegor256 commented 8 years ago

@tmjee one more comment from me. Keep in mind, NULL is a very bad thing, in most cases. Well, in all cases.

tmjee commented 8 years ago

@yegor256 done

yegor256 commented 8 years ago

@rultor try to merge

rultor commented 8 years ago

@rultor try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 8 years ago

@rultor try to merge

@yegor256 Done! FYI, the full log is here (took me 4min)

dmarkov commented 8 years ago

@dmzaytsev Much obliged! I have added 22 mins to your account in payment "66848066", 190 hours and 58 mins spent... review comments (c=7) added as a bonus... +22 added to your rating, current score is: +1340

dmarkov commented 8 years ago

@rultor deploy now pls

rultor commented 8 years ago

@rultor deploy now pls

@dmarkov OK, I'll try to deploy now. You can check the progress here

rultor commented 8 years ago

@rultor deploy now pls

@dmarkov Done! FYI, the full log is here (took me 5min)