Open amihaiemil opened 8 years ago
@dmarkov Can you see about this one pls?
@yegor256 can you have a look here pls? Thanks
@yegor256 ping
@yegor256 Don't forget about this pls
@yegor256 ping
@amihaiemil thanks for the ticket, your account was topped for 15 mins, payment AP-9NT580487T283314A
In this test a
fork
is created, patched and some assertions are made. The test works fine, but the mocks are done illogically, making the test (and thus relation between fork and repo) hard to understand:There are 2 mock servers started:
container
andforksContainer
. The createdrepo
comes fromforksContainer
, while the createdfork
comes fromcontainer
. This does not make sense, they should both come from the same server, at least for test simplicity.Furthermore, with the current setup, if you try to
iterate
over the createdrepo
's forks, you get an exception, sinceforksContainer
does not know to return thefork
.The test works just fine and the logic is much simpler if we just use
container
for both therepo
and thefork
and get rid offorkContainer
.