jcabi / jcabi-github

Java Object-Oriented Wrapper of GitHub API, with a fake implementation of the entire GitHub API (for your tests)
https://github.jcabi.com
Other
305 stars 141 forks source link

build is broken at RtReleaseAssetsITCase.uploadsAssets #709

Closed yegor256 closed 10 years ago

yegor256 commented 10 years ago

build is broken:

Failed tests:
  RtReleaseAssetsITCase.uploadsAssets:57 HTTP response status is not equal to 201:
422 Unprocessable Entity [https://api.github.com/repos/jcabi-github-test/test/releases]
Server: GitHub.com
Date: Tue, 01 Apr 2014 18:25:12 GMT
Content-Type: application/json; charset=utf-8
Status: 422 Unprocessable Entity
X-RateLimit-Limit: 5000
X-RateLimit-Remaining: 4673
X-RateLimit-Reset: 1396377914
X-OAuth-Scopes: admin:org, admin:public_key, admin:repo_hook, delete_repo, gist, notifications, repo, user
X-Accepted-OAuth-Scopes:
X-GitHub-Media-Type: github.beta
X-Content-Type-Options: nosniff
Content-Length: 220
Access-Control-Allow-Credentials: true
Access-Control-Expose-Headers: ETag, Link, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval
Access-Control-Allow-Origin: *
X-GitHub-Request-Id: 36EDCE79:7A26:1EE9258:533B0488

{"message":"Validation Failed","documentation_url":"http://developer.github.com/v3/repos/releases/#create-a-release","errors":[{"resource":"Release","code":"custom","message":"Published releases must have a valid tag"}]}
Expected: HTTP response with status 201
     but: was <422 Unprocessable Entity [https://api.github.com/repos/jcabi-github-test/test/releases]
Server: GitHub.com
Date: Tue, 01 Apr 2014 18:25:12 GMT
Content-Type: application/json; charset=utf-8
Status: 422 Unprocessable Entity
X-RateLimit-Limit: 5000
X-RateLimit-Remaining: 4673
X-RateLimit-Reset: 1396377914
X-OAuth-Scopes: admin:org, admin:public_key, admin:repo_hook, delete_repo, gist, notifications, repo, user
X-Accepted-OAuth-Scopes:
X-GitHub-Media-Type: github.beta
X-Content-Type-Options: nosniff
Content-Length: 220
Access-Control-Allow-Credentials: true
Access-Control-Expose-Headers: ETag, Link, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval
Access-Control-Allow-Origin: *
X-GitHub-Request-Id: 36EDCE79:7A26:1EE9258:533B0488

{"message":"Validation Failed","documentation_url":"http://developer.github.com/v3/repos/releases/#create-a-release","errors":[{"resource":"Release","code":"custom","message":"Published releases must have a valid tag"}]}>

Tests run: 93, Failures: 1, Errors: 0, Skipped: 13

see http://relics.rultor.com.s3.amazonaws.com/urn:facebook:1531296526/jcabi-github-on-commit/stdout/2014-04-01T18:10:00Z/log.txt

dmarkov commented 10 years ago

I'll find a developer for the task soon...

dmarkov commented 10 years ago

@longtimeago it's your task now, the budget is 30 mins, go ahead

longtimeago commented 10 years ago

@yegor256 I've tried several cases: 1) Create release with same tag several times (same as in error log) 2) Create one release and then another (without delete) 3) Try to upload several assets for one release But no luck in reproducing the issue So, unfortunately, nothing to fix

yegor256 commented 10 years ago

let's merge your attempts into master? I mean, your unit tests, where you tried to reproduce the issue

longtimeago commented 10 years ago

@yegor256 Actually, I don't create new tests, only change existing one in following ways and run it several times so produce desired state

yegor256 commented 10 years ago

let's commit it?

longtimeago commented 10 years ago

@yegor256 Sure, here they are https://github.com/jcabi/jcabi-github/pull/723

longtimeago commented 10 years ago

@yegor256 Please, review

dmarkov commented 10 years ago

@longtimeago the task is your hands for the last 12 days.. keep in mind that if it's not closed in the next 40 hours, it will be re-assigned to someone else, see No Obligations principle

longtimeago commented 10 years ago

@yegor256 We are waiting for #730 here

yegor256 commented 10 years ago

@dmarkov we're waiting for #730

dmarkov commented 10 years ago

@dmarkov we're waiting for #730

@yegor256 of course, let's wait for #730

longtimeago commented 10 years ago

@yegor256 Please, close the issue, as pull request is merged (https://github.com/jcabi/jcabi-github/pull/723)

longtimeago commented 10 years ago

and looks like #730 do not affect this issue

yegor256 commented 10 years ago

thanks

dmarkov commented 10 years ago

@longtimeago 30 mins added to your account (payment number 38741086), many thanks for your contribution!