search

jcabi / jcabi-immutable

Primitive Java Immutable Collections, like Array, ArraySet, etc.
https://immutable.jcabi.com
Other
31 stars 18 forks source link

Deprecated for mutators #31

Closed nesterov-n closed 8 years ago

nesterov-n commented 8 years ago

This reffers #17

dmarkov commented 8 years ago

@nesterov-n Thanks, I will ask someone to do a code review here, thanks for your pull request

dmarkov commented 8 years ago

@mkordas could you please review this pull request

mkordas commented 8 years ago

@nesterov-n I'm on it

mkordas commented 8 years ago

@nesterov-n can you please check failing build?

mkordas commented 8 years ago

@nesterov-n now I see. Please just suppress NoJavadocForOverrideMethods for these classes and add proper @deprecated.

nesterov-n commented 8 years ago

@mkordas can you help me? How can I suppress NoJavadocForOverrideMethods check for class? I'm not familiar with qulice tool

mkordas commented 8 years ago

@nesterov-n here you have sample suppression: https://github.com/teamed/qulice/blob/4243a5b5e2a05f01e8af9dcb353f4a798ca36aaf/qulice-maven-plugin/src/it/hibernate-validator-check/src/main/java/com/qulice/foo/Sample.java#L18

mkordas commented 8 years ago

@nesterov-n ping

nesterov-n commented 8 years ago

@mkordas Adding deprecated javaDoc tag causes too many check fails (JavadocMethodCheck, RegexpMultilineCheck). Maybe best way is suppress MissingDeprecatedCheck for whole file?

mkordas commented 8 years ago

@nesterov-n OK, I'm fine with this solution. It should be clear why these methods are deprecated without additional docs.

mkordas commented 8 years ago

@nesterov-n looks good!

mkordas commented 8 years ago

@rultor merge

rultor commented 8 years ago

@rultor merge

@mkordas Thanks for your request. @yegor256 Please confirm this.

yegor256 commented 8 years ago

@rultor merge

rultor commented 8 years ago

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 8 years ago

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 4min)

dmarkov commented 8 years ago

@mkordas paid, thanks, added 23 mins to your account, payment 56de85744b766c3bd800041a, 90 hours and 11 mins was spent. review comments (c=8) added as a bonus. added +23 to your rating, now it is equal to +8319

dmarkov commented 8 years ago

@rultor deploy pls

rultor commented 8 years ago

@rultor deploy pls

@dmarkov OK, I'll try to deploy now. You can check the progress here

rultor commented 8 years ago

@rultor deploy pls

@dmarkov Done! FYI, the full log is here (took me 7min)