search

jcabi / jcabi-manifests

Java library for convenient reading of MANIFEST.MF files available in classpath
https://manifests.jcabi.com
Other
60 stars 22 forks source link

mvn qulice:check -Pqulice founds violations in file headers #16

Closed RomanKisilenko closed 9 years ago

RomanKisilenko commented 9 years ago 
[ERROR] /src/main/java/com/jcabi/manifests/ClasspathMfs.java[2]: Line does not match expected header line of ' * BSD License'. (HeaderCheck)

The issue is similar to https://github.com/jcabi/jcabi-email/issues/11

yegor256 commented 9 years ago

@RomanKisilenko how can I reproduce it?

RomanKisilenko commented 9 years ago

The issue is reproducible for me by executing

mvn qulice:check -Pqulice
dmarkov commented 9 years ago

this task will get someone's attention soon

dmarkov commented 9 years ago

@maurezen it's in your hands now, please proceed

maurezen commented 9 years ago

@dmarkov Created a pull request here #17

maurezen commented 9 years ago

@dmarkov @yegor256 shouldn't there also be my account label on this ticket?

dmarkov commented 9 years ago

@romankisilenko thanks for the report, I topped your acc for 15 mins, payment ID 50348224

maurezen commented 9 years ago

@RomanKisilenko pull request #17 merged to master, please close the issue.

maurezen commented 9 years ago

@RomanKisilenko please close the issue.

dmarkov commented 9 years ago

once 16-4036a3b3 puzzle is resolved, this ticket will be complete

RomanKisilenko commented 9 years ago

@dmarkov Should I close this issue now or should we wait?

yegor256 commented 9 years ago

@RomanKisilenko up to you. if you are happy with the current solution, close it. if the problem is not solved and still blocks you, keep it open

dmarkov commented 9 years ago

@maurezen thanks, paid, 30 mins to your account, payment ID is 50616213; +30 added to your rating, at the moment it is: +885

dmarkov commented 9 years ago

@romankisilenko the last puzzle 16-4036a3b3/#20 solved