jcabi / jcabi-manifests

Java library for convenient reading of MANIFEST.MF files available in classpath
https://manifests.jcabi.com
Other
60 stars 22 forks source link

Manifests class doesn't work correctly when being executed in parallel #2

Closed krzyk closed 10 years ago

krzyk commented 10 years ago

When Manifests is used in surefire tests that are executed concurrently it sometimes returns results set by other test when injecting values.

yegor256 commented 10 years ago

Thanks for reporting. I'm not sure how to fix this, since Manifests is a static class available for everybody concurrently. Maybe introduce Manifests.lock() and Manifests.unlock() methods, which will allow unit tests to isolate their injections..

yegor256 commented 10 years ago

@krzyk check version 1.0. I removed this injection/reverting mechanism entirely. The problem disappeared, as I see

dmarkov commented 10 years ago

@yegor256 the issue is yours, please help

yegor256 commented 10 years ago

@krzyk could you please check this issue? I believe it's fixed

dmarkov commented 10 years ago

@yegor256 Thanks so much! Your account was topped up for 31 mins (transaction ID is 000-af0fc60b)