search

jcabi / jcabi-manifests

Java library for convenient reading of MANIFEST.MF files available in classpath
https://manifests.jcabi.com
Other
60 stars 22 forks source link

Lack of language level restrictions in the pom #36

Closed westonal closed 8 years ago

westonal commented 8 years ago

Problem: Build servers build against Java 1.7 Lack of language restriction in POM means that locally Java 1.8 is acceptable and it is not apparent until we start PR that we have used some Java 8 method/class.

The ide and local build should restrict language use, the simplest way would be to include this in the POM.

dmarkov commented 8 years ago

@yegor256 dispatch this issue please, see par.21

westonal commented 8 years ago

@dmarkov what's happening with this task?

yegor256 commented 8 years ago

@westonized our JDK version is 1.6 and inherit that from jcabi-parent POM. I don't think we should duplicate that information in our own POM. or I didn't understand the question?

westonal commented 8 years ago

@yegor256 If it is inherited, how come I have no issues building against java 1.8 features and methods locally. And I only discover it's a problem when I start a pull request.

That is I can locally build this project with mvn clean install -Pqulice referencing Java 8 methods and classes.

westonal commented 8 years ago

@yegor256 It looks like you have done what this task is suggesting anyway in the pom here: bc4391c9c969c75d6339b0a1dbac6ed53354a873

yegor256 commented 8 years ago

@westonized OK, I'm closing. thanks.