Refactor the Manifests class to an immutable

westonal commented 8 years ago

In line with objects should be immutable, refactor the Manifests class to be an immutable.

Acceptance criteria:

Manifests is immutable, that is no exposed methods will change its internal state
Manifests no longer implements Map<String, String>, though it should keep get method
Manifests provides a mutable map copy from a method: Map<string, string> asMap() providing an upgrade route for anyone relying on its previous implementation of Map
Remove @SuppressWarnings("PMD.TooManyMethods") from the class, as most of the old Map methods will be gone

dmarkov commented 8 years ago

@yegor256 please pay attention to this issue (par.21)

dmarkov commented 8 years ago

@westonized thanks for this report, I added 15 mins to your account, in transaction AP-92K25680T0309344B

proshin-roman commented 6 years ago

@westonal @dmarkov the issue has been fixed in a pull request #43. Please check if the ticket can be closed now.

jcabi / jcabi-manifests