search

jcabi / jcabi-manifests

Java library for convenient reading of MANIFEST.MF files available in classpath
https://manifests.jcabi.com
Other
60 stars 22 forks source link

#38: Refactor the Manifests class to an immutable #43

Closed proshin-roman closed 6 years ago

proshin-roman commented 6 years ago

I've made Manifests file immutable. As well I added asMap() method that returns a copy of an internal map of attributes. Method keySet() returns a copy of keys set too.

0crat commented 6 years ago

@yegor256/z please, pay attention to this pull request

0crat commented 6 years ago

Job #43 is now in scope, role is REV

yegor256 commented 6 years ago

@proshin-roman see my comment. Also, what was the problem you were solving? What was wrong?

proshin-roman commented 6 years ago

@yegor256 that's strange that the ticket is not mentioned there automatically. This pull request has been created for the ticket #38 and it meets the requirements of the ticket.

yegor256 commented 6 years ago

@rultor merge

rultor commented 6 years ago

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

0crat commented 6 years ago

Job gh:jcabi/jcabi-manifests#43 is not assigned, can't get start time

rultor commented 6 years ago

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 8min)

0crat commented 6 years ago

The job #43 is now out of scope