search

jcaddel / maven-s3-wagon

Multi-threaded wagon to connect Maven with Amazon S3
123 stars 50 forks source link

unable to download sources and javadoc #16

Closed SierraGolf closed 10 years ago

SierraGolf commented 10 years ago

for some reason it seems that the sources and the javadoc though present in the bucket can not be downloaded.

jcaddel commented 10 years ago

The source and javadocs for the latest release are publicly available from Maven Central:

http://search.maven.org/#artifactdetails|org.kuali.maven.wagons|maven-s3-wagon|1.2.1|jar

and also from Kuali's S3 bucket:

http://maven.kuali.org.s3.amazonaws.com/release/org/kuali/maven/wagons/maven-s3-wagon/1.2.1/maven-s3-wagon-1.2.1-javadoc.jar http://maven.kuali.org.s3.amazonaws.com/release/org/kuali/maven/wagons/maven-s3-wagon/1.2.1/maven-s3-wagon-1.2.1-sources.jar

SierraGolf commented 10 years ago

I think I was not clear enough. What I mean is it is not possible to get sources and documentation for dependencies which are only available in s3, meaning the plugin fails to download those.

This is reproducable from the IDE (e.g. idea) and also from command line.

jcaddel commented 10 years ago

There should not be any dependencies that are only available from Kuali's S3 bucket. All dependencies (even transitive dependencies) should be available from Maven Central

Which dependencies are you not able to acquire source and javadoc for?

SierraGolf commented 10 years ago

... we are still not on the same page.

when uploading dependencies including javadocs and sources through the s3 wagon plugin, it is not possible to retrieve the javadocs and sources for those dependencies from s3.

uploading works, downloading doesn't.

jcaddel commented 10 years ago

Are you saying you are having difficulty downloading javadocs and sources for dependencies of the maven-s3-wagon? or are you saying something else?

SierraGolf commented 10 years ago

I am saying that I can not download sources and javadocs WITH the s3 wagon plugin of artifacts I deployed WITH the s3 wagon plugin.

jcaddel commented 10 years ago

That sounds odd indeed. If you examine the S3 ACL of the main artifact, and then compare that with the S3 ACL of the javadoc/sources artifacts, are they the same? They should be.

From the perspective of the wagon, there is no difference between a javadoc/source artifact and the main artifact.

The Maven core supplies the wagon with a list of artifacts to upload. The wagon then uploads everything in that list the exact same way.

SierraGolf commented 10 years ago

I just double checked. It seems to be a bug with idea and version ranges. From CLI I can retrieve the sources and documentation correctly. So it does not seem to be a problem with the s3 plugin after all.