search

jcaddel / maven-s3-wagon

Multi-threaded wagon to connect Maven with Amazon S3
123 stars 50 forks source link

Add a way to unset the precanned acl #41

Closed leamingrad closed 5 years ago

leamingrad commented 5 years ago

This MR allows configuration to disable sending a pre-canned ACL by setting their server settings as follows:

<server>
  <id>s3.snapshot</id>
  <filePermissions></filePermissions>
</server>

This is useful when uploading objects to S3 with a user that does not have the s3:PutObjectAcl permission. In this case, POST requests to S3 that have a canned ACL are rejected - so it is better to be able to not specify an ACL, which will cause the bucket default to be used.

I am happy to add tests/docs as appropriate, but I couldn't work out what was needed at a first pass.

leamingrad commented 5 years ago

Noticed that this repository seems to be dead and there are similar PRs in existance so closing this - for anyone that stumbles on this, I switched to https://github.com/seahen/maven-s3-wagon which is essentially the same as this repo but with this fix merged in.