search

jcaddel / maven-s3-wagon

Multi-threaded wagon to connect Maven with Amazon S3
123 stars 50 forks source link

duplicate resource mime.types #6

Closed yegor256 closed 11 years ago

yegor256 commented 12 years ago

com.amazonaws:aws-java-sdk:1.3.8, which you depend on, already contains this mime.types file. Why are you duplicating it?

jcaddel commented 11 years ago

If I remember correctly, there were a few mime types either missing or incorrect in the file from AWS and there was not a way to update/override the mime.types file embedded in the SDK.

If there was a way to pass an override file into, com.amazonaws.services.s3.internal.Mimetypes.getInstance() that would be better.

There were only a handful of entries I wanted to alter/add but did not see a way of doing so incrementally.

Something like, Mimetypes.getInstance("my-mime.types"). It would use its internal config file, but let you pass in an override file that would get merged with its internal file.

This way the file bundled with the maven-s3-wagon would only have 5-6 lines in it.

yegor256 commented 11 years ago

Did you ask Amazon to add such a feature to SDK?

jcaddel commented 11 years ago

Nope. Not yet anyway. Your comment questioning why there was a mime.types bundled into the wagon prompted me to re-visit that and figure out why I did that in the first place :)

I will most likely file a feature request with them for that shortly.

jcaddel commented 11 years ago

Actually, don't they have a github repo up? If there is something about the duplicate mime.types bundled into the wagon that causes issues for you, quickest path to getting to a good solution on this would be to create a pull request containing a better solution.

Their repo is at https://github.com/amazonwebservices/aws-sdk-for-java.git

If it became available from them, I would definitely work that into the wagon and get rid of the duplication.

yegor256 commented 11 years ago

I think that this mimes.types files belongs to their artifact, but is duplicated in yours. Provided that, I can only assume that Amazon SDK won't do anything with their file. It's the problem to be solved in your wagon. But it's up to you. It's not critical for my case.

jcaddel commented 11 years ago

Closing this as an issue.